Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix brakeman warning about possible command injection #20130

Merged
merged 1 commit into from
May 7, 2020
Merged

fix brakeman warning about possible command injection #20130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions config/brakeman.ignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,5 @@
{
"ignored_warnings": [
{
"warning_type": "Command Injection",
"warning_code": 14,
"fingerprint": "14cf1baf5a62a0f109a2deb71920db195735f3054b031e50513d433f1566a670",
"check_name": "Execute",
"message": "Possible command injection",
"file": "lib/miq_apache/control.rb",
"line": 55,
"link": "http://brakemanscanner.org/docs/warning_types/command_injection/",
"code": "system(\"kill -WINCH #{`pgrep -P 1 httpd`.chomp.to_i}\")",
"render_path": null,
"location": {
"type": "method",
"class": "MiqApache::Control",
"method": "s(:self).stop"
},
"user_input": "`pgrep -P 1 httpd`.chomp.to_i",
"confidence": "Medium",
"note": "The chomp.to_i ensures we get a number and we protect against 0 with a conditional. The only other possible avenue for attack is if the attacker could replace pgrep, but then they already have root access, so it's a moot point."
},
{
"warning_type": "File Access",
"warning_code": 16,
Expand Down
2 changes: 1 addition & 1 deletion lib/miq_apache/control.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ def self.start
def self.stop
if ENV["CONTAINER"]
pid = `pgrep -P 1 httpd`.chomp.to_i
system("kill -WINCH #{pid}") if pid > 0
Process.kill("WINCH", pid) if pid > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

else
run_apache_cmd('stop')
end
Expand Down