[JANSA] Renamed provider_foreman to configuration_manager #20183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed provider_foreman specific features, links etc to configuration_manager Jansa specific PR for backport of ManageIQ#19949
h-kataria
requested review from
agrare,
bdunne,
Fryguy,
gtanzillo and
kbrock
as code owners
miq-bot
changed the title
2 tasks
chessbyte
changed the title
|
Checked commit h-kataria@b8c60f8 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
|
What were the conflicts that prevented a cherry-pick? I thought all other feature changes were going to be backported, so I wouldn't have expected this. |
|
I think #19924 is causing the conflict. |
|
I'm pretty sure ConfigurationProfiles are required for @h-kataria 's changes to work, so I think that one should be jansa/yes? as well. @bdunne ? |
|
Yeah, I think those should go back. I marked them jansa/yes? |
|
Ok, once those are back, @simaishi can you try a normal cherry-pick based backport of this one? |
|
This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed provider_foreman specific features, links etc to configuration_manager
Jansa specific PR for backport of #19949