MiqExpression#contains improvement #20199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
miq_expression_expansion
branch
from
717f9d2
to
f01c37e
Compare
|
Checked commits kbrock/manageiq@086b836~...f01c37e with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
kbrock
changed the title
kbrock
changed the title
kbrock
commented
May 22, 2020
| @@ -1373,8 +1367,8 @@ def to_arel(exp, tz) | |||
| # Only support for tags of the main model | |||
| if exp[operator].key?("tag") | |||
| tag = Tag.parse(exp[operator]["tag"]) | |||
| ids = tag.model.find_tagged_with(:any => parsed_value, :ns => tag.namespace).pluck(:id) | |||
| tag.model.arel_attribute(:id).in(ids) | |||
| ids = tag.target.find_tagged_with(:any => parsed_value, :ns => tag.namespace).pluck(:id) | |||
There was a problem hiding this comment.
I can change this to not pluck the id and become an inner query.
It would remove some arel, but would add a few lines to make that work smothly
|
kicking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
MiqExpression::Target#*_supports_sql?instead of rewriting that logic.added 36 lines of tests and 10 lines of comments - so feature for nothing and the code for free :)