Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing compliance events for container project and physical server. #20267

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Add missing compliance events for container project and physical server. #20267

merged 1 commit into from
Jun 10, 2020

Conversation

lfu
Copy link
Member

@lfu lfu commented Jun 10, 2020

No description provided.

@lfu lfu requested review from agrare and bdunne as code owners June 10, 2020 14:20
bdunne
bdunne reviewed Jun 10, 2020
View reviewed changes
db/fixtures/miq_event_definitions.csv

#
# Physical Server Operations
#
physicalserver_compliance_check,Physical Server Compliance Check,Default,compliance
physicalserver_compliance_passed,Physical Server Compliance Passed,Default,compliance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are some of these physical_server and others don't have the underscore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

physicalserver is the right format for compliance events.
Looks like physical_server is used for other operational events.

@chessbyte chessbyte self-assigned this Jun 10, 2020
@chessbyte chessbyte merged commit cc688dd into ManageIQ:master Jun 10, 2020
simaishi pushed a commit that referenced this pull request Jun 10, 2020
@chessbyte @simaishi
Merge pull request #20267 from lfu/compliance_events
f0d8fbf 
Add missing compliance events for container project and physical server.

(cherry picked from commit cc688dd)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit f0d8fbfd28a9d964a9733e78060c242a9a977c5c
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Wed Jun 10 12:15:14 2020 -0400

    Merge pull request #20267 from lfu/compliance_events

    Add missing compliance events for container project and physical server.

    (cherry picked from commit cc688ddd70d7fcda64a51b03c1ad77e97cba13dd)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne bdunne left review comments

@agrare agrare Awaiting requested review from agrare agrare is a code owner

Assignees

@chessbyte chessbyte

Labels
bug core/policy jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lfu @simaishi @bdunne @chessbyte @agrare