Conditionally add the messaging environment vars to worker containers #20268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
reviewed
Jun 10, 2020
Fryguy
reviewed
Jun 10, 2020
If we don't provide a value for MESSAGING_TYPE we shouldn't assume that the kafka secret is present. If we try to deploy a container with env vars referencing the secret the container won't be created. ManageIQ/manageiq-pods#541
carbonin
force-pushed
the
conditionally_add_messaging_env
branch
from
2c26351
to
b2e5683
Compare
carbonin
added a commit
to carbonin/manageiq-pods
that referenced
this pull request
Jun 10, 2020
The application doesn't actually rely on these services so we don't need to deploy them by default. If a user wants events published to kafka they can still enable the flag on deploy and consume those events from a separate application. Requires ManageIQ/manageiq#20268 Fixes ManageIQ#541
mali-chainzee
pushed a commit
to mali-chainzee/manageiq-pods
that referenced
this pull request
Jun 11, 2020
The application doesn't actually rely on these services so we don't need to deploy them by default. If a user wants events published to kafka they can still enable the flag on deploy and consume those events from a separate application. Requires ManageIQ/manageiq#20268 Fixes ManageIQ#541
simaishi
pushed a commit
that referenced
this pull request
Jun 11, 2020
Conditionally add the messaging environment vars to worker containers (cherry picked from commit 2a9cfb3)
|
Jansa backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't provide a value for MESSAGING_TYPE we shouldn't assume
that the kafka secret is present. If we try to deploy a container
with env vars referencing the secret the container won't be created.
ManageIQ/manageiq-pods#541