Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the memory limits for metrics and queue workers #20383

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Bump the memory limits for metrics and queue workers #20383

merged 1 commit into from
Jul 23, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 23, 2020 •
edited
Loading

It has been seen when running in containers that the reported memory usage is a little higher than RSS which is a little higher than PSS.

This means that if we are on the edge on an appliance the same usage will be over the limit on pods.

@agrare
Bump the memory limits for metrics and queue workers
7085adc 
It has been seen when running in containers that the reported memory
usage is a little higher than RSS which is a little higher than PSS.

This means that if we are on the edge on an appliance the same usage
will be over the limit on pods.
@agrare agrare requested a review from jrafanie as a code owner July 23, 2020 18:33
@agrare agrare requested a review from carbonin July 23, 2020 18:34
@miq-bot
Copy link
Member

miq-bot commented Jul 23, 2020

Checked commit agrare@7085adc with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@agrare
Copy link
Member Author

agrare commented Jul 23, 2020

Test failure unrelated, #20384 should fix it

@carbonin carbonin closed this Jul 23, 2020
@carbonin carbonin reopened this Jul 23, 2020
@jrafanie jrafanie self-assigned this Jul 23, 2020
@jrafanie jrafanie merged commit cca2bd8 into ManageIQ:master Jul 23, 2020
@agrare agrare deleted the bump_memory_thresholds branch July 23, 2020 20:39
simaishi pushed a commit that referenced this pull request Jul 24, 2020
@jrafanie @simaishi
Merge pull request #20383 from agrare/bump_memory_thresholds
a3aaa15 
Bump the memory limits for metrics and queue workers

(cherry picked from commit cca2bd8)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit a3aaa1549fbc850038c5511ae585b0d8b43cf773
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Thu Jul 23 16:35:08 2020 -0400

    Merge pull request #20383 from agrare/bump_memory_thresholds

    Bump the memory limits for metrics and queue workers

    (cherry picked from commit cca2bd8e9c8839deff16ff62a2be49558885f8f4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbonin carbonin carbonin approved these changes

@jrafanie jrafanie jrafanie approved these changes

Assignees

@jrafanie jrafanie

Labels
bug core/workers jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agrare @miq-bot @simaishi @jrafanie @carbonin @gtanzillo