Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow kafka exceptions to cause EmsEvent.add_queue to fail #20440

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Don't allow kafka exceptions to cause EmsEvent.add_queue to fail #20440

merged 1 commit into from
Aug 13, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 13, 2020 •
edited
Loading

If there are issues publishing events to kafka we shouldn't allow them to cause the main MiqQueue EmsEvent.add to fail

cc @abellotti

ManageIQ/manageiq-pods#607

@agrare
Don't allow kafka exceptions to cause EmsEvent.add_queue to fail
aab6b9c 
If there are issues publishing events to kafka we shouldn't allow them
to cause the main MiqQueue EmsEvent.add to fail
@miq-bot
Copy link
Member

miq-bot commented Aug 13, 2020

Checked commit agrare@aab6b9c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@agrare agrare requested a review from gtanzillo August 13, 2020 14:31
@chessbyte chessbyte self-assigned this Aug 13, 2020
@chessbyte chessbyte merged commit eb7d827 into ManageIQ:master Aug 13, 2020
@agrare agrare deleted the catch_exceptions_publishing_events_to_kafka branch August 13, 2020 14:54
simaishi pushed a commit that referenced this pull request Aug 17, 2020
@chessbyte @simaishi
Merge pull request #20440 from agrare/catch_exceptions_publishing_eve…
f30e55d 
…nts_to_kafka

Don't allow kafka exceptions to cause EmsEvent.add_queue to fail

(cherry picked from commit eb7d827)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit f30e55d35dca9cfaa0ccaa271f1dcb64f00cb94c
Author: Oleg Barenboim <chessbyte@gmail.com>
Date:   Thu Aug 13 10:53:20 2020 -0400

    Merge pull request #20440 from agrare/catch_exceptions_publishing_events_to_kafka

    Don't allow kafka exceptions to cause EmsEvent.add_queue to fail

    (cherry picked from commit eb7d827ab244e9ff8f0a30fbab57189c3b5ce2c6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo Awaiting requested review from gtanzillo

Assignees

@chessbyte chessbyte

Labels
bug core/events jansa/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agrare @miq-bot @simaishi @chessbyte