Link user to the sessions create to enable lookup of all sessions by user #20477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessbyte
reviewed
Aug 24, 2020
| end | ||
|
|
||
| def link_user_to_session(request) | ||
| session_id = request.session_options[:id] |
There was a problem hiding this comment.
Does the code need to account for request being nil?
gtanzillo
force-pushed
the
link-user-to-session-id
branch
from
aa0665f
to
fa3c8ee
Compare
|
Checked commit gtanzillo@fa3c8ee with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint app/models/user.rb
|
This was referenced Sep 15, 2020
|
schema changes were merged, as was #20549 |
|
This pull request is not mergeable. Please rebase and repush. |
|
Closing in favor of #20601 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype for using the sessions table to link a user to open sessions.
This change creates a
has_manylink between theusersandsessionstables. The approach creates the link after a user successfully authenticates, at which point the user instance and the request containing the session id are available. The nice thing about this approach is that is should work regardless of the configured session store because it doesn’t rely on the session data being present in the sessions table (as it would be for ActiveRecord::SessionStore)Depends on schema PR: TBD
Fixes: #20476