Skip to content

Added gettext calls around MiqReport.GROUPINGS #20537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
h-kataria merged 1 commit into from
Sep 11, 2020
Merged

Added gettext calls around MiqReport.GROUPINGS #20537

h-kataria merged 1 commit into from
Sep 11, 2020

Conversation

@Maria-Cordero-ibm
Copy link
Contributor

@Maria-Cordero-ibm Maria-Cordero-ibm commented Sep 10, 2020 •
edited
Loading

Adding required gettext calls for #7302

@Maria-Cordero-ibm Maria-Cordero-ibm mentioned this pull request Sep 10, 2020
Merged
@skateman
Copy link
Member

skateman commented Sep 10, 2020

@miq-bot add_reviewer @skateman

@miq-bot miq-bot requested a review from skateman September 10, 2020 21:24
@Maria-Cordero-ibm Maria-Cordero-ibm changed the title PR #7320 Dependency - Report Calc translate Added gettext calls around MiqReport.GROUPINGS Sep 11, 2020
@h-kataria h-kataria self-assigned this Sep 11, 2020
@h-kataria
Copy link
Contributor

h-kataria commented Sep 11, 2020

@Maria-Cordero-ibm can you take a look at failing spec test

@h-kataria h-kataria closed this Sep 11, 2020
@h-kataria h-kataria reopened this Sep 11, 2020
@Maria-Cordero-ibm
Copy link
Contributor Author

Maria-Cordero-ibm commented Sep 11, 2020

The CI issues are unrelated to the changes in the PR and are also happening on master.

@miq-bot
Copy link
Member

miq-bot commented Sep 11, 2020

Checked commit Maria-Cordero-ibm@cddc72e with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

skateman
skateman approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@Fryguy Fryguy closed this Sep 11, 2020
@Fryguy Fryguy reopened this Sep 11, 2020
@h-kataria h-kataria merged commit b201ba5 into ManageIQ:master Sep 11, 2020
simaishi pushed a commit that referenced this pull request Sep 18, 2020
@h-kataria @simaishi
Merge pull request #20537 from Maria-Cordero-ibm/8670_Report_translation
973253a 
Added gettext calls around MiqReport.GROUPINGS

(cherry picked from commit b201ba5)
@simaishi
Copy link
Contributor

simaishi commented Sep 18, 2020

Jansa backport details:

$ git log -1
commit 973253a556465d88871e673a09a72eed14a8eb62
Author: Harpreet Kataria <hkataria@redhat.com>
Date:   Fri Sep 11 14:17:20 2020 -0400

    Merge pull request #20537 from Maria-Cordero-ibm/8670_Report_translation

    Added gettext calls around MiqReport.GROUPINGS

    (cherry picked from commit b201ba54eb71cda0fbc65c37425945357fb50d66)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

1 more reviewer

@skateman skateman skateman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@h-kataria h-kataria

Labels

bug internationalization jansa/backported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Maria-Cordero-ibm @skateman @h-kataria @miq-bot @simaishi @Fryguy @gtanzillo