Redis sessions #20612
Closed
Redis sessions #20612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
reviewed
Sep 28, 2020
|
I kind of like this PR...not sure about incurring another gem and its dependencies, but otherwise it looks really good. If we did decide to go the redis route as the default instead of memcached, then we'd need a way to carry that on the appliances/operator |
Fryguy
reviewed
Sep 28, 2020
Fryguy
reviewed
Sep 28, 2020
Fryguy
reviewed
Sep 28, 2020
Merged
Add the ability to use redis as the session store. Currently alternatives include memcached, sql, and in-memory. Changing the session store is done in settings: ```yaml :server: :session_store: redis :session: :redis_url: redis://127.0.0.1/2 ``` The url is of the form: `redis://[:password@]host[:port][/db-number]`
|
Checked commit kbrock@43bd97f with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint |
|
too low on the priority queue we need to just use rails built in mechanism for sessions / cache. Then all this stuff would be free. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to use redis as the session store. Currently alternatives
include memcached, sql, and in-memory.
Changing the session store is done in settings:
The url is of the form:
redis://[:password@]host[:port][/db-number]