Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IVANCHUK] Native console support for ivanchuk #20640

Merged

Conversation

mzazrivec
Copy link
Contributor

@mzazrivec mzazrivec commented Oct 1, 2020

Add native viewer console to allow users download the connection file from RHV instances.

This is ivanchuk-only version of #19675 (cherry picked from commit 2586a45).

This PR needs to go in with ManageIQ/manageiq-providers-ovirt#528 and ManageIQ/manageiq-ui-classic#7372

https://bugzilla.redhat.com/show_bug.cgi?id=1884211

Add native viewer console to allow users download the
connection file from RHV instances.

(cherry picked from commit 2586a45)
@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2020

Checked commit mzazrivec@eddd960 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
5 files checked, 1 offense detected

app/models/vm/operations.rb

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@simaishi simaishi merged commit 3f931e3 into ManageIQ:ivanchuk Oct 6, 2020
@simaishi simaishi mentioned this pull request Oct 6, 2020
@mzazrivec mzazrivec deleted the native_console_support_for_ivanchuk branch October 6, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants