Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer class attribute over cattr_accessor in miq_policy #20790

Merged
merged 1 commit into from
Nov 9, 2020
Merged

prefer class attribute over cattr_accessor in miq_policy #20790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/models/miq_policy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class MiqPolicy < ApplicationRecord

attr_accessor :reserved

cattr_accessor :associations_to_get_policies
class_attribute :associations_to_get_policies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of self To clarify the variable had me confused. Also the << not seeming to work but += did (for arrays). Could you explain the issue before and why we are not concerned with introducing bugs here?


@@built_in_policies = nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to change too? This is a cattr.


Expand Down