Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that options[:ems_id] is an Array when passed as an ENV var #20809

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 12, 2020

When passing the EMS_ID as an ENV var we need to ensure that it is an array to be consistent with how OptionParser is processing it

Longer term we should be able to drop EMS_ID as an array now that #20345 is passing the parent manager ems_id only for the queue_name.

When passing the EMS_ID as an ENV var we need to ensure that it is an
array to be consistent with how OptionParser is processing it
@agrare agrare force-pushed the fix_ems_workers_ems_id_non_array branch from 34ce23d to 5b609bb Compare November 12, 2020 19:22
@miq-bot
Copy link
Member

miq-bot commented Nov 12, 2020

Checked commit agrare@5b609bb with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@jrafanie jrafanie merged commit 8ac612f into ManageIQ:master Nov 12, 2020
@agrare agrare deleted the fix_ems_workers_ems_id_non_array branch November 12, 2020 21:10
@agrare
Copy link
Member Author

agrare commented Nov 13, 2020

@gtanzillo @jrafanie can we mark this kasparov/yes

@jrafanie
Copy link
Member

@gtanzillo @jrafanie can we mark this kasparov/yes

Yes. 💯

@agrare
Copy link
Member Author

agrare commented Nov 13, 2020

cc @simaishi

simaishi pushed a commit that referenced this pull request Nov 13, 2020
Ensure that options[:ems_id] is an Array when passed as an ENV var

(cherry picked from commit 8ac612f)
@simaishi
Copy link
Contributor

Kasparov backport details:

$ git log -1
commit efe017f4272237a48c2ba3214ac5fcbd43f31b73
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Thu Nov 12 16:08:23 2020 -0500

    Merge pull request #20809 from agrare/fix_ems_workers_ems_id_non_array

    Ensure that options[:ems_id] is an Array when passed as an ENV var

    (cherry picked from commit 8ac612f334c88d7a33eab7531537ba65eb5447a9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants