Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-restart systemd workers results in duplicates #20824

Merged

Commits on Nov 18, 2020

  1. Auto-restart systemd workers results in duplicates

    Because the worker GUID is part of the systemd service when a systemd
    worker is restarted by systemd it will get a new PID but reuse the old
    GUID.  If MiqServer deletes the worker row because it doesn't see the
    PID then you end up with a service restarting and failing to find its
    row constantly.
    agrare committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    b734fad View commit details
    Browse the repository at this point in the history
  2. Refactor MiqServer at_startup

    agrare committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    ccd6a06 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2020

  1. Write systemd service files on startup not in sync_workers

    When the systemd worker option was first introduced as a prototype there
    was a setting that would control if systemd or the normal forking worker
    mode was used.  This setting was per worker, and was done in
    sync_workers so that you could change the setting "on-the-fly" without
    restarting the entire evmserverd process.  This made it much easier to
    try out using systemd on one or two workers very quickly.
    
    Now that systemd is the default for appliances the ability to change
    this dynamically isn't very helpful, and writing out systemd unit files
    during sync_workers is just a lot of overhead.
    
    Moving the writing of systemd unit files to miq_server startup removes
    the overhead per-sync_workers-loop and allows us to update the contents
    of the files without checking .exist? (which was done due to the
    frequency with which it was being run).
    agrare committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    f7d11bb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d215045 View commit details
    Browse the repository at this point in the history