[EmbeddedAnsible] Ensure newline for auth_key in MachineCredential #20845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes `.ensure_newline_for_ssh_key` a shared method from the base class so other classes can make use of it.
NickLaMuro
requested review from
agrare,
Fryguy and
gtanzillo
as code owners
NickLaMuro
force-pushed
the
embedded_ansible_machine_credential_newline
branch
from
d00d810
to
3bcc188
Compare
|
Checked commits NickLaMuro/manageiq@cf27ae6~...3bcc188 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
@miq-bot add_label ivanchuk/yes |
Fryguy
reviewed
Dec 1, 2020
app/models/manageiq/providers/embedded_ansible/automation_manager/machine_credential.rb
Show resolved
Hide resolved
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2020
…edential_newline [EmbeddedAnsible] Ensure newline for auth_key in MachineCredential (cherry picked from commit 3dad919) https://bugzilla.redhat.com/show_bug.cgi?id=1893014
|
Ivanchuk backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2020
…edential_newline [EmbeddedAnsible] Ensure newline for auth_key in MachineCredential (cherry picked from commit 3dad919)
simaishi
pushed a commit
that referenced
this pull request
Dec 1, 2020
…edential_newline [EmbeddedAnsible] Ensure newline for auth_key in MachineCredential (cherry picked from commit 3dad919)
|
Jansa backport details: |
|
Kasparov backport details: |
simaishi
added
ivanchuk/backported
jansa/backported
kasparov/backported
and removed
ivanchuk/yes
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #20771
Original Description
SSH formats like
OPENSSHrequire that a newline exist on the last line, otherwise it is considered an invalid format.This adds a
before_savebefore_validationcallback to the model to ensure that it adds a newline to the key in case it was stripped off by the UI or via other means.Links