[Gemfile] Lock the config gem #20882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had a recent change to it that broke our build: rubyconfig/config#277 https://travis-ci.com/github/ManageIQ/manageiq-api/jobs/456702122#L1985-L1994 (master) https://travis-ci.com/github/ManageIQ/manageiq-api/builds/207478687#L1995-L2004 (kasparov) https://travis-ci.com/github/ManageIQ/manageiq-api/builds/207524405#L2113-L2122 (jansa) So for now, lock the version to a known working version for us.
Fryguy
approved these changes
Dec 9, 2020
|
Checked commit NickLaMuro@288fd13 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
simaishi
pushed a commit
that referenced
this pull request
Dec 9, 2020
[Gemfile] Lock the config gem (cherry picked from commit 5c3b3b2)
|
Kasparov backport details: |
simaishi
pushed a commit
that referenced
this pull request
Dec 9, 2020
[Gemfile] Lock the config gem (cherry picked from commit 5c3b3b2)
|
Jansa backport details: |
|
New version release with reverted PR introducing the issue: https://github.com/rubyconfig/config/releases/tag/2.2.3 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
configgem had a recent change to it that was recently released which broke our build:So for now, lock the version to a known working version for us.
Links