Fix key collision with Thread[:current_request] #20973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've moved to manageiq-loggers, the ContainerLogger has code that expects that if Thread[:current_request] is set, it will be a request object that responds to :request_id. The RequestStartedOnMiddleware, however, happens to use the same key and stores only the request path, leading to `undefined method request_id for "/path/to/wherever"` Since this particular key's usage is isolated to the middleware, we can name it whatever we want, so this commit chooses a name that is less likely to collide.
|
cc @abellotti |
NickLaMuro
reviewed
Jan 20, 2021
|
Checked commit Fryguy@0109f04 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
|
@Fryguy should this go back to kasparov? |
simaishi
pushed a commit
that referenced
this pull request
Jan 29, 2021
Fix key collision with Thread[:current_request] (cherry picked from commit c52be90)
|
Kasparov backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we've moved to manageiq-loggers, the ContainerLogger has code
that expects that if Thread[:current_request] is set, it will be a
request object that responds to :request_id. The
RequestStartedOnMiddleware, however, happens to use the same key and
stores only the request path, leading to
undefined method request_id for "/path/to/wherever"Since this particular key's usage is isolated to the middleware, we can
name it whatever we want, so this commit chooses a name that is less
likely to collide.