Fix sporadic test failure when MiqEvent is not yet defined #21010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrafanie Please review. |
The test is checking that MiqEvents were raised to the queue when space is not available for the backup/dump feature, however depending on test loading order, it's possible that MiqEvent is not defined. The code that raises the event has an explicit check for `defined?(::MiqEvent)` because it can run outside of the Rails environment context from a rake task. This commit changes the test to ensure that the MiqEvent class is defined, so we can verify that the event is raised. Closes ManageIQ#20986
Fryguy
force-pushed
the
fix_evm_database_ops_sproadic_bug
branch
2 times, most recently
from
fff9dfb
to
a4be3a5
Compare
|
Checked commit Fryguy@5f1be08 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
jrafanie
approved these changes
Feb 3, 2021
|
👍 to merge when green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is checking that MiqEvents were raised to the queue when space
is not available for the backup/dump feature, however depending on test
loading order, it's possible that MiqEvent is not defined. The code
that raises the event has an explicit check for
defined?(::MiqEvent)because it can run outside of the Rails environment context from a rake
task.
This commit changes the test to ensure that the MiqEvent class is
defined, so we can verify that the event is raised.
Closes #20986