Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MiqProvisionWorkflow#initialize method and subclasses #21014

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Refactor MiqProvisionWorkflow#initialize method and subclasses #21014

wants to merge 10 commits into from

Commits on Sep 17, 2024

  1. Extract initial_pass? method

    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    55f03f0 View commit details
    Browse the repository at this point in the history

  2. Extract load_source_object method

    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f5a4f36 View commit details
    Browse the repository at this point in the history

  3. Extract initialize_dialogs method

    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    bfcae12 View commit details
    Browse the repository at this point in the history

  4. Extract configure_dialogs method

    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    316b6f7 View commit details
    Browse the repository at this point in the history

  5. Remove MiqProvisionOrchWorkflow#initialize method as it is not identi… 

    …cal to MiqProvisionVirtWorkflow#initialize
    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f3bd847 View commit details
    Browse the repository at this point in the history

  6. Refactor MiqProvisionVirtWorkflow#initialize to leverage MiqRequestWo… 

    …rkflow#initialize
    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4597573 View commit details
    Browse the repository at this point in the history

  7. DRYed up load_source_object method by creating class method source_ob… 

    …ject_class
    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    694eeff View commit details
    Browse the repository at this point in the history

  8. Move extracted methods to private area of the code

    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    3e3e977 View commit details
    Browse the repository at this point in the history

  9. Check options[:skip_dialog_load] outside of methods initialize_dialog… 

    …s and configure_dialogs
    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5a62aae View commit details
    Browse the repository at this point in the history

  10. Removed private_class_method on source_object_class as it was causing… 

    … spec failures
    @chessbyte @kbrock
    chessbyte authored and kbrock committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    c7243c9 View commit details
    Browse the repository at this point in the history