Prefer rollup records with tags to grouping in chargeback #21059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lpichler Cannot apply the following label because they are not recognized:
All labels for |
lpichler
force-pushed
the
prefer_rollups_tags_to_grouping_in_chargeback
branch
from
0d92b66
to
308f884
Compare
lpichler
force-pushed
the
prefer_rollups_tags_to_grouping_in_chargeback
branch
from
308f884
to
8bf9fec
Compare
|
Checked commits lpichler/manageiq@dba8cd1~...8bf9fec with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint app/models/chargeback/consumption_with_rollups.rb
|
gtanzillo
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is applicable only for tag group feature in chargeback reports.
Each group on result report is calculated with all metric rollups in the consumptions.
But it is possible that all metric rollups don't have tag names in whole consumptions.
For example: When Vm was untagged in middle of month then we need to reflect it in chargeback calculation for each group on report result and we should use only metric rollups with tag name (in
MetricRollup#tag_names)When we have resource tagged - this is no applied. We use all metric rollups of resource in the consumption.
@miq-bot assign @gtanzillo
@miq-bot add_label bug, chargeback