-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Oracle as a vendor and OS Type #21080
Conversation
So we have a line-item for this in the pluggability checklist #19440 but since this is a rails validation I'm getting a cyclic dependency error when trying to load up leaf_subclasses |
If you have a vendor image we should also add that to decorators for consistency: https://github.com/ManageIQ/manageiq-decorators/tree/master/app/assets/images/svg |
oh actually it's already there - https://github.com/ManageIQ/manageiq-decorators/blob/master/app/assets/images/svg/vendor-oracle_cloud.svg |
Well that's convenient 😄 |
Oh wait, I thought this was a vendor... (i.e. oracle cloud), as opposed to an OS (oracle linux). we don't have an image for oracle linux. |
@@ -44,6 +44,7 @@ class VmOrTemplate < ApplicationRecord | |||
"amazon" => "Amazon", | |||
"redhat" => "RedHat", | |||
"openstack" => "OpenStack", | |||
"oracle" => "Oracle", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To clarify, this is Oracle Cloud.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -28,6 +28,7 @@ class OperatingSystem < ApplicationRecord | |||
["linux_coreos", %w(coreos)], | |||
["linux_esx", %w(vmnixx86 vmwareesxserver esxserver vmwareesxi)], | |||
["linux_solaris", %w(solaris)], | |||
["linux_oracle", %w(oracle)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is Oracle Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we just need a os-linux_oracle
icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can probably symlink like we do for other images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked commit agrare@ac236a2 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint app/models/operating_system.rb
|
Add Oracle as a vendor and OS Type (cherry picked from commit 633ccf4)
Backported to
|
Add Oracle as a vendor and OS Type (cherry picked from commit 633ccf4)
Add Oracle as a supported vendor and oracle linux as a supported OperatingSystem type
Required for: