Fix ansible_runner content seeding #21086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fetch_ansible_galaxy code, when called at run-time works correctly, however, this method, meant for seeding galaxy roles at build time, incorrectly looked at the root directory instead of the roles directory, and so did nothing.
Fryguy
force-pushed
the
fix_ansible_runner_seed
branch
from
b38c0b5
to
7b52ef6
Compare
|
Checked commit Fryguy@7b52ef6 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
agrare
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetch_ansible_galaxy code, when called at run-time works correctly,
however, this method, meant for seeding galaxy roles at build time,
incorrectly looked at the root directory instead of the roles directory,
and so did nothing.
@agrare Please review.