Support ruby 3 #21531

jrafanie · 2021-10-29T21:55:00Z

Let's upgrade to ruby 3

Need new gems:

Support ruby 3 arguments and drop alias_method_chain in favor of Module#prepend jquery-rjs#9 ~~Needs merge, release, then we can use that release~~ 0.1.1.3 released
support ruby 3.0 foreman_api_client#20 ~~needs release, then, we can bump the provider to use this version~~ 1.0.2 released
Bump to foreman_api_client 1.0.2 for ruby 3 support manageiq-providers-foreman#107
Update to prawn 2.4.0, which added ruby 3 support. ruport/ruport#64 merged, ~~needs release~~ released as 1.8.0

Dependencies:

After this PR is merged:

Update all workflows/ci.yaml for all repos to test with ruby 3
Enable ruby 3 for rpm build manageiq-rpm_build#304
Enable ruby 3 for building images manageiq-pods#891
Update appliances to use ruby 3 manageiq-appliance-build#524

Update code coverage using ruby 2.7 to instead use 3.0, such as:

 - name: Report code coverage
   if: "${{ github.ref == 'refs/heads/master' && matrix.ruby-version == '2.7' }}"

spec/models/manageiq/providers/ansible_playbook_workflow_spec.rb

jrafanie · 2022-01-10T19:21:30Z

@miq-bot cross-repo-tests /all ManageIQ/inventory_refresh#97

From Pull Request: ManageIQ/manageiq#21531

jrafanie · 2022-01-10T19:27:27Z

@miq-bot cross-repo-tests /all ManageIQ/inventory_refresh#97

From Pull Request: ManageIQ/manageiq#21531

jrafanie · 2022-01-10T20:02:30Z

@miq-bot cross_repo_tests #21531, /all including #21531, ManageIQ/inventory_refresh#97

From Pull Request: ManageIQ/manageiq#21531

jrafanie · 2022-01-11T17:17:14Z

@miq-bot cross_repo_tests #21531,/core including #21531, ManageIQ/inventory_refresh#97

From Pull Request: ManageIQ/manageiq#21531

Depends on ruby 3 support via ManageIQ/manageiq#21531 Depends on ManageIQ/manageiq-rpm_build#304 for ruby 3 rpm builds

Fryguy · 2022-09-20T22:06:30Z

Gemfile

@@ -1,5 +1,5 @@
 raise "Ruby versions < 2.6.0 are unsupported!" if RUBY_VERSION < "2.6.0"


Should this change to make 2.7 the minimum?

Fryguy · 2022-09-20T22:07:22Z

Gemfile

@@ -85,7 +85,7 @@ gem "mime-types",                       "~>3.0",             :require => false,

 # Modified gems (forked on Github)
 gem "handsoap",                         "=0.2.5.5",          :require => false, :source => "https://rubygems.manageiq.org" # for manageiq-gems-pending only
-gem "ruport",                           "=1.7.0.3",                             :source => "https://rubygems.manageiq.org"
+gem "ruport",                           "~>1.8.0"


If this is no longer modified we should move it into the "regular gems" section.

See: https://github.com/ruport/ruport/pull/64/files

ManageIQ/jquery-rjs#9

https://github.com/rspec/rspec-mocks/issues 1460

jrafanie · 2022-09-21T13:15:50Z

I'm finished suggested changes and restarted the cross repo tests: ManageIQ/manageiq-cross_repo-tests#706

I think we're ready to merge when things are green.

miq-bot · 2022-09-21T13:22:14Z

Checked commits jrafanie/manageiq@04e0622~...f9469b7 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
21 files checked, 0 offenses detected
Everything looks fine. ⭐

jrafanie · 2022-09-21T14:18:11Z

@agrare @bdunne @kbrock @Fryguy Ok, this is green, the 3.0 results are the same as the 2.7 ones (ui-service and api fail in the same way): ManageIQ/manageiq-cross_repo-tests#706

I think we're ready to merge this and start building pods and appliances and ensuring all the repositories are testing with 3.0 going forward.

jrafanie · 2022-09-21T14:22:45Z

Gemfile

-raise "Ruby versions < 2.6.0 are unsupported!" if RUBY_VERSION < "2.6.0"
-raise "Ruby versions >= 3.0.0 are unsupported!" if RUBY_VERSION >= "3.0.0"
+raise "Ruby versions < 2.7.0 are unsupported!" if RUBY_VERSION < "2.7.0"
+raise "Ruby versions >= 3.1.0 are unsupported!" if RUBY_VERSION >= "3.1.0"


2.7 minimum and 3.0.x maximum

bdunne

jrafanie requested a review from Fryguy as a code owner October 29, 2021 21:55

miq-bot added wip dependencies labels Oct 29, 2021

chessbyte added the ruby3 label Nov 1, 2021

chessbyte mentioned this pull request Nov 2, 2021

Support Ruby 3.0 #21536

Closed

1 task

kbrock mentioned this pull request Nov 12, 2021

avoid faker #21559

Merged

jrafanie force-pushed the ruby3 branch 2 times, most recently from 46a3d9c to f1187a7 Compare January 7, 2022 17:45

jrafanie requested review from agrare and kbrock as code owners January 7, 2022 17:45

Fryguy reviewed Jan 7, 2022

View reviewed changes

spec/models/manageiq/providers/ansible_playbook_workflow_spec.rb Outdated Show resolved Hide resolved

jrafanie force-pushed the ruby3 branch from f1187a7 to fcdc189 Compare January 10, 2022 19:09

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jan 10, 2022

Running tests for jrafanie

11b7c8f

From Pull Request: ManageIQ/manageiq#21531

miq-bot mentioned this pull request Jan 10, 2022

[BOT] Cross repo test for ManageIQ/manageiq#21531 ManageIQ/manageiq-cross_repo-tests#566

Closed

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jan 10, 2022

Running tests for jrafanie

09957f4

From Pull Request: ManageIQ/manageiq#21531

miq-bot mentioned this pull request Jan 10, 2022

[BOT] Cross repo test for ManageIQ/manageiq#21531 ManageIQ/manageiq-cross_repo-tests#567

Closed

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jan 10, 2022

Running tests for jrafanie

c3dea38

From Pull Request: ManageIQ/manageiq#21531

miq-bot mentioned this pull request Jan 10, 2022

[BOT] Cross repo test for ManageIQ/manageiq#21531 ManageIQ/manageiq-cross_repo-tests#568

Closed

jrafanie force-pushed the ruby3 branch from fcdc189 to db2ca44 Compare January 10, 2022 19:56

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jan 10, 2022

Running tests for jrafanie

2659e13

From Pull Request: ManageIQ/manageiq#21531

miq-bot mentioned this pull request Jan 10, 2022

[BOT] Cross repo test for ManageIQ/manageiq#21531 ManageIQ/manageiq-cross_repo-tests#569

Open

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Jan 11, 2022

Running tests for jrafanie

b982578

From Pull Request: ManageIQ/manageiq#21531

miq-bot mentioned this pull request Jan 11, 2022

[BOT] Cross repo test for ManageIQ/manageiq#21531 ManageIQ/manageiq-cross_repo-tests#572

Closed

miq-bot added core/embedded ansible labels Jan 18, 2022

jrafanie force-pushed the ruby3 branch from db2ca44 to 5ef0f85 Compare January 19, 2022 14:11

jrafanie added a commit to jrafanie/manageiq-pods that referenced this pull request Sep 20, 2022

Enable ruby 3 for building images

e4bd263

Depends on ruby 3 support via ManageIQ/manageiq#21531 Depends on ManageIQ/manageiq-rpm_build#304 for ruby 3 rpm builds

jrafanie mentioned this pull request Sep 20, 2022

Enable ruby 3 for building images ManageIQ/manageiq-pods#891

Merged

jrafanie closed this Sep 20, 2022

jrafanie reopened this Sep 20, 2022

Fryguy reviewed Sep 20, 2022

View reviewed changes

Allow ruby 3.0

04e0622

jrafanie force-pushed the ruby3 branch from 05c5c9e to 4bbef67 Compare September 21, 2022 13:11

jrafanie added 7 commits September 21, 2022 09:13

Update to ruport 1.8.0 for ruby 3 support

2de88a5

See: https://github.com/ruport/ruport/pull/64/files

Use jquery-rjs with ruby 3 fix

ac415b0

ManageIQ/jquery-rjs#9

Test with ruby 3

a53e4e1

rspec-mocks 3.10.3 requires "with" to be explicit with hashes vs. kwargs

9d3a7ed

https://github.com/rspec/rspec-mocks/issues 1460

Make changes to work with inventory refresh 2.0

05f222c

Fix cops for changed specs

eef47c1

Require ruby 2.7+

f9469b7

jrafanie force-pushed the ruby3 branch from 23d4044 to f9469b7 Compare September 21, 2022 13:14

jrafanie changed the title ~~[WIP] Support ruby 3~~ Support ruby 3 Sep 21, 2022

miq-bot removed the wip label Sep 21, 2022

jrafanie commented Sep 21, 2022

View reviewed changes

agrare approved these changes Sep 21, 2022

View reviewed changes

bdunne approved these changes Sep 21, 2022

View reviewed changes

bdunne merged commit de23798 into ManageIQ:master Sep 22, 2022

bdunne assigned bdunne and unassigned Fryguy Sep 22, 2022

jrafanie deleted the ruby3 branch September 22, 2022 14:34

Fryguy added this to the Oparin milestone Sep 23, 2022

jrafanie mentioned this pull request Oct 9, 2023

Fix some http 5.1.1 test failures IBM/ruby-sdk-core#41

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ruby 3 #21531

Support ruby 3 #21531

jrafanie commented Oct 29, 2021 •

edited

Loading

jrafanie commented Jan 10, 2022 •

edited

Loading

jrafanie commented Jan 10, 2022

jrafanie commented Jan 10, 2022

jrafanie commented Jan 11, 2022

Fryguy Sep 20, 2022

Fryguy Sep 20, 2022

jrafanie commented Sep 21, 2022

miq-bot commented Sep 21, 2022

jrafanie commented Sep 21, 2022

jrafanie Sep 21, 2022 •

edited

Loading

bdunne left a comment

		@@ -1,5 +1,5 @@
		raise "Ruby versions < 2.6.0 are unsupported!" if RUBY_VERSION < "2.6.0"

Support ruby 3 #21531

Support ruby 3 #21531

Conversation

jrafanie commented Oct 29, 2021 • edited Loading

Need new gems:

Dependencies:

After this PR is merged:

jrafanie commented Jan 10, 2022 • edited Loading

jrafanie commented Jan 10, 2022

jrafanie commented Jan 10, 2022

jrafanie commented Jan 11, 2022

Fryguy Sep 20, 2022

Choose a reason for hiding this comment

Fryguy Sep 20, 2022

Choose a reason for hiding this comment

jrafanie commented Sep 21, 2022

miq-bot commented Sep 21, 2022

jrafanie commented Sep 21, 2022

jrafanie Sep 21, 2022 • edited Loading

Choose a reason for hiding this comment

bdunne left a comment

Choose a reason for hiding this comment

jrafanie commented Oct 29, 2021 •

edited

Loading

jrafanie commented Jan 10, 2022 •

edited

Loading

jrafanie Sep 21, 2022 •

edited

Loading