Support GitHub Actions #21682
Merged
Support GitHub Actions #21682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
support_github_actions
branch
from
a25781b
to
92630e8
Compare
bdunne
reviewed
Feb 4, 2022
| system!("gem install bundler -v '#{bundler_version}' --conservative") | ||
| system!("bundle config path #{root.join('vendor/bundle').expand_path}", :chdir => root) if ENV["CI"] | ||
| system!("echo 'gem: --no-ri --no-rdoc --no-document' > ~/.gemrc") if ENV['TRAVIS'] | ||
| system!("gem install bundler -v '#{bundler_version}' --conservative") unless ENV["GITHUB_ACTIONS"] |
There was a problem hiding this comment.
Why don't we want to do this for Github Actions?
There was a problem hiding this comment.
Because there are actions that do this for us.
Fryguy
force-pushed
the
support_github_actions
branch
from
92630e8
to
9922a70
Compare
|
Checked commit Fryguy@9922a70 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint lib/manageiq/environment.rb
|
|
@Fryguy I see you are actively working on GH Actions. How can I help? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.