Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub Actions #21683

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Switch to GitHub Actions #21683

merged 1 commit into from
Feb 7, 2022

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 7, 2022 •
edited
Loading

TODO:

  • PARALLEL=true
  • arm / other arches?

Fryguy
Fryguy commented Feb 7, 2022
View reviewed changes
.github/workflows/ci.yaml Outdated
ci:
runs-on: ubuntu-latest
strategy:
fail-fast: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Don't forget to remove this.

@Fryguy Fryguy force-pushed the github_actions branch 2 times, most recently from 615d9ff to 393f4f9 Compare February 7, 2022 17:37
@Fryguy Fryguy mentioned this pull request Feb 7, 2022
Closed
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2022

Checked commit Fryguy@a2ae146 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
4 files checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy
Copy link
Member Author

Fryguy commented Feb 7, 2022

@jrafanie...I noticed we run security on both 2.6 and 2.7...is that necessary? Thoughts? Was thinking I could change this to just run spec on 2.6 and that's it.

@chessbyte chessbyte self-assigned this Feb 7, 2022
@chessbyte chessbyte merged commit 0318b45 into ManageIQ:master Feb 7, 2022
@Fryguy Fryguy deleted the github_actions branch February 7, 2022 18:52
@jrafanie
Copy link
Member

jrafanie commented Feb 7, 2022

@jrafanie...I noticed we run security on both 2.6 and 2.7...is that necessary? Thoughts? Was thinking I could change this to just run spec on 2.6 and that's it.

Yeah, that makes sense. I don't think it's required to do all rubies. Technically, bundle-audit will have ruby CVEs it scans for so it might be a good reminder to bump ruby versions in some repos/branches but agree, it's probably not worth it to run for more than 1 ruby.

@Fryguy Fryguy mentioned this pull request Jul 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

@jrafanie jrafanie Awaiting requested review from jrafanie jrafanie is a code owner

@kbrock kbrock Awaiting requested review from kbrock kbrock is a code owner

Assignees

@chessbyte chessbyte

Labels
developer test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Fryguy @miq-bot @jrafanie @chessbyte