Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactor ManageIQ setup #21684

Closed
wants to merge 1 commit into from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 7, 2022

This commit refactors the ManageIQ core and plugin setup and update to

  • DRY up duplication
  • Use consistent ENV vars for skipping parts
  • Log nicer locally and on CI
  • Prevent duplicate bundle update on CI

WIP, because I might want to refactor some of the before_install scripts from the plugins as well, similar to ManageIQ/manageiq-providers-amazon#744

@miq-bot miq-bot added the wip label Feb 7, 2022
@Fryguy Fryguy force-pushed the refactor_manageiq_setup branch 4 times, most recently from 7ce52d3 to a35ead9 Compare February 7, 2022 21:56
This commit refactors the ManageIQ core and plugin setup and update to
- DRY up duplication
- Use consistent ENV vars for skipping parts
- Log nicer locally and on CI
- Prevent duplicate bundle update on CI
@miq-bot
Copy link
Member

miq-bot commented Feb 7, 2022

Checked commit Fryguy@65edf4a with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint
1 file checked, 10 offenses detected

lib/manageiq/environment.rb

  • ❗ - Line 11, Col 7 - Style/GlobalStdStream - Use $stderr instead of STDERR.
  • ❗ - Line 11, Col 7 - Style/StderrPuts - Use warn instead of STDERR.puts to allow such output to be disabled.
  • ❗ - Line 139, Col 42 - Style/HashSyntax - Use hash rockets syntax.
  • ❗ - Line 165, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
  • ❗ - Line 168, Col 7 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
  • ❗ - Line 20, Col 1 - Naming/HeredocDelimiterNaming - Use meaningful heredoc delimiters.
  • ❗ - Line 23, Col 7 - Rails/Exit - Do not use exit in Rails applications.
  • ❗ - Line 76, Col 11 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
  • ❗ - Line 88, Col 15 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.
  • ❗ - Line 90, Col 15 - Rails/Output - Do not write to stdout. Use Rails's logger if you want to log.

@miq-bot
Copy link
Member

miq-bot commented Apr 1, 2022

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Feb 27, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy reopened this Mar 13, 2023
@Fryguy Fryguy removed the stale label Mar 13, 2023
@miq-bot
Copy link
Member

miq-bot commented Mar 13, 2023

This pull request is not mergeable. Please rebase and repush.

@kbrock
Copy link
Member

kbrock commented Mar 15, 2023

nice changes

You know, I often want to call ./bin/update --no-automate --no-bundle
It would be easy for me to add tab _complete().
I keep telling myself that env vars are just the same thing but for me it just isn't.

This resonating with you at all?

@miq-bot miq-bot added the stale label Jun 19, 2023
@miq-bot miq-bot closed this Jun 19, 2023
@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants