-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Refactor ManageIQ setup #21684
Conversation
7ce52d3
to
a35ead9
Compare
This commit refactors the ManageIQ core and plugin setup and update to - DRY up duplication - Use consistent ENV vars for skipping parts - Log nicer locally and on CI - Prevent duplicate bundle update on CI
a35ead9
to
65edf4a
Compare
Checked commit Fryguy@65edf4a with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint lib/manageiq/environment.rb
|
This pull request is not mergeable. Please rebase and repush. |
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
This pull request is not mergeable. Please rebase and repush. |
nice changes You know, I often want to call This resonating with you at all? |
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
This commit refactors the ManageIQ core and plugin setup and update to
WIP, because I might want to refactor some of the before_install scripts from the plugins as well, similar to ManageIQ/manageiq-providers-amazon#744