[WIP] Use auto-model-class for ContainerImages #21828
Conversation
|
@miq-bot cross-repo-tests manageiq-providers-openshift manageiq-providers-kubernetes |
From Pull Request: ManageIQ/manageiq#21828
agrare
force-pushed
the
fix_docker_images_nil_type
branch
from
20a984a
to
982a190
Compare
agrare
changed the title
|
Marking WIP until the kubernetes and openshift PRs are up |
|
Good find. |
From Pull Request: ManageIQ/manageiq#21828
Having the `:model_class` set to `::ContainerImage` meant that auto_model_class was not being called, causing any records which did not have a `:type` explicitly set by the parser would end up having a type set to the base `::ContainerImage` class.
From Pull Request: ManageIQ/manageiq#21828
agrare
force-pushed
the
fix_docker_images_nil_type
branch
from
982a190
to
e46eea8
Compare
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation. |
|
Checked commit agrare@e46eea8 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
|
This pull request is not mergeable. Please rebase and repush. |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
2 similar comments
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
|
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
Having the
:model_classset to::ContainerImagemeant that auto_model_class was not being called, causing any records which did not have a:typeexplicitly set by the parser would end up having a type set to the base::ContainerImageclass.In the case of openshift, only images from an image registry had their
:typeset toManageIQ::Providers::Openshift::ContainerManager::ContainerImageThis will require a data migration and likely changes to the Kubernetes provider because it doesn't appear that they have a subclass for this
Cross-repo Tests: ManageIQ/manageiq-cross_repo-tests#632
Follow-up PRs:
#21825