Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tooltips for Group button #22572

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Add missing tooltips for Group button #22572

merged 1 commit into from
Jun 19, 2023

Conversation

akhilkr128
Copy link
Member

Aims to fix : ManageIQ/manageiq-providers-ibm_cic#25

Before

Screenshot 2023-06-19 at 6 39 51 PM

After

Screenshot 2023-06-19 at 6 38 51 PM

@Fryguy Fryguy self-assigned this Jun 19, 2023
@Fryguy Fryguy added the bug label Jun 19, 2023
@akhilkr128 akhilkr128 mentioned this pull request Jun 19, 2023
Closed
@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2023

Checked commit akhilkr128@3f925dd with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

agrare
agrare approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@agrare agrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 we might have others (e.g. ManageIQ::Providers::IbmCloud::VPC::NetworkManager) that we should look for

@agrare agrare merged commit e67fc18 into ManageIQ:master Jun 19, 2023
@Fryguy
Copy link
Member

Fryguy commented Jun 28, 2023

I didn't realize this added a huge trailing whitespace in the en/yml file - will fix in a followup PR.

@Fryguy
Copy link
Member

Fryguy commented Jun 28, 2023

Backported to petrosian in commit a10a28f.

commit a10a28f1cba5dda94fcfc0a8655371b47a32754c
Author: Adam Grare <adam@grare.com>
Date:   Mon Jun 19 09:33:35 2023 -0400

    Merge pull request #22572 from akhilkr128/tootltip_bugfix
    
    Add missing tooltips for Group button
    
    (cherry picked from commit e67fc18209c843f76e663641a85bc9aa75e09a9f)

Fryguy pushed a commit that referenced this pull request Jun 28, 2023
@agrare @Fryguy
Merge pull request #22572 from akhilkr128/tootltip_bugfix
a10a28f 
Add missing tooltips for Group button

(cherry picked from commit e67fc18)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare agrare approved these changes

@Fryguy Fryguy Fryguy approved these changes

@jrafanie jrafanie Awaiting requested review from jrafanie jrafanie is a code owner

Assignees

@Fryguy Fryguy

Labels
bug petrosian/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CIC name in dashboard is the "type" column exploded out
4 participants
@akhilkr128 @miq-bot @Fryguy @agrare