Separate role access restrictions for catalog items #22573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the ability to set access restrictions for service templates separately from vms, the default user roles should set :service_templates to the same value as :vms so that there is no change to the default behavior.
jaywcarman
requested review from
agrare,
bdunne,
Fryguy and
kbrock
as code owners
I copied the
|
jaywcarman
force-pushed
the
separate_role_access_restrictions_for_service_templates
branch
from
dd735cd
to
4ee4e8c
Compare
|
Checked commits jaywcarman/manageiq@6072d2c~...4ee4e8c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
jaywcarman
deleted the
separate_role_access_restrictions_for_service_templates
branch
Fryguy
reviewed
Jul 10, 2023
This was referenced Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22421
Previously user role access restriction for Catalog Items, Orchestration
Stacks, Key Pairs, Services, VMs, and Templates were set with a single
control (vm_restriction).
Break out the ability to set access restriction for catalog items
separately from other types.
This feature is useful when an administrator wants to give a group
access to a catalog item (service_template) but wants any services
ordered to be restricted to the individual users.
Corresponding PRs: