Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ResourceAction#fqname=nil to clear ae_* #22600

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Jul 5, 2023

Now that resource actions can have either embedded_automate ae_* values or a configuration_script_id it is helpful to clear the ae_* values for an existing resource action.

Ref: ManageIQ/manageiq-ui-classic#8815

@miq-bot
Copy link
Member

miq-bot commented Jul 5, 2023

Checked commit agrare@95b8e32 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@Fryguy Fryguy merged commit 4b5fe60 into ManageIQ:master Jul 5, 2023
8 checks passed
@Fryguy Fryguy self-assigned this Jul 5, 2023
@Fryguy
Copy link
Member

Fryguy commented Jul 5, 2023

Backported to petrosian in commit 221864a.

commit 221864a702055f5bfd66a2c552b7bd4546e01166
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Jul 5 13:54:22 2023 -0400

    Merge pull request #22600 from agrare/allow_fqname_eql_set_to_nil
    
    Allow `ResourceAction#fqname=nil` to clear `ae_*`
    
    (cherry picked from commit 4b5fe6070fff1f9eb4d51283f3b0ccfa786628e4)

Fryguy added a commit that referenced this pull request Jul 5, 2023
Allow `ResourceAction#fqname=nil` to clear `ae_*`

(cherry picked from commit 4b5fe60)
@agrare agrare deleted the allow_fqname_eql_set_to_nil branch July 5, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants