Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vim performance state time interval #22606

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Vim performance state time interval #22606

merged 4 commits into from
Aug 1, 2023

Commits on Jul 14, 2023

  1. Move get_time_interval to VimPerformanceState 

    this is returning the time range for a vps, moved it to that code
    @kbrock
    kbrock committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    610473d View commit details
    Browse the repository at this point in the history

  2. Hardcode VimPerformanceState timestamp range 

    VPS use a hard coded 1.hour range for the hourly captures.
This avoids looking up a record just to come up with the same conclusion
    @kbrock
    kbrock committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    230ed31 View commit details
    Browse the repository at this point in the history

  3. No longer pass an object to get_time_interval 

    VimPErformanceStates are only stored for hourly.
And this is only called for hourly values

So passing the object is not needed.

If we change that and need to pass the object in the future, I'm sorry
    @kbrock
    kbrock committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    134ca05 View commit details
    Browse the repository at this point in the history

  4. rename Statistic variable capture_interval that is really a date range

    @kbrock
    kbrock committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cd86162 View commit details
    Browse the repository at this point in the history