Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs for Vim Performance States #22607

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jul 8, 2023

Documenting the parts of VimPerformanceState that I will be changing

added docs around using a scope to populate the relation
This is only used in one place by rollups.

I had thought an array would work, but it does not.
@miq-bot
Copy link
Member

miq-bot commented Jul 8, 2023

Checked commits kbrock/manageiq@a643bcd~...9617543 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
3 files checked, 4 offenses detected

spec/lib/miq_preloader_spec.rb

spec/models/metric/ci_mixin/state_finders_spec.rb

@Fryguy Fryguy merged commit f63d508 into ManageIQ:master Jul 10, 2023
@kbrock kbrock deleted the capture_vim_performance_spec1 branch July 10, 2023 13:56
@kbrock kbrock mentioned this pull request Jul 25, 2023
1 task
Fryguy added a commit that referenced this pull request Jul 25, 2023
Specs for Vim Performance States

(cherry picked from commit f63d508)
@Fryguy
Copy link
Member

Fryguy commented Jul 25, 2023

Backported to petrosian in commit 80053a9.

commit 80053a91501476086d6344a78be31f25c2a80c74
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Jul 10 09:12:16 2023 -0400

    Merge pull request #22607 from kbrock/capture_vim_performance_spec1
    
    Specs for Vim Performance States
    
    (cherry picked from commit f63d50886b544f64d8bdd57b1b55c5524627bb62)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants