Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config option in 6.1.7+ instead of an initializer #22852

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jrafanie
Copy link
Member

In Rails 6.1.7, the config option sets:
ActiveRecord::Base.raise_int_wider_than_64bit

In Rails 7.0.8, the same option sets:
ActiveRecord.raise_int_wider_than_64bit

This change hides the internals and uses the public interface via the configuration option.

See the change that landed in 6.1.7 here:
rails/rails@4f44aa9

and 7.0 here:
rails/rails@82bcdc0

In Rails 6.1.7, the config option sets:
ActiveRecord::Base.raise_int_wider_than_64bit

In Rails 7.0.8, the same option sets:
ActiveRecord.raise_int_wider_than_64bit

This change hides the internals and uses the public interface
via the configuration option.

See the change that landed in 6.1.7 here:
rails/rails@4f44aa9

and 7.0 here:
rails/rails@82bcdc0
@miq-bot
Copy link
Member

miq-bot commented Jan 24, 2024

Checked commit jrafanie@b09e1f9 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 👍

@bdunne bdunne merged commit b039573 into ManageIQ:master Jan 24, 2024
6 checks passed
@bdunne bdunne assigned bdunne and unassigned Fryguy Jan 24, 2024
@jrafanie jrafanie deleted the move_initializer_to_config_option branch January 24, 2024 17:37
@jrafanie jrafanie mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants