Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Remove default value try2 #22923

Closed
wants to merge 3 commits into from
Closed

[WIP] Remove default value try2 #22923

wants to merge 3 commits into from

Commits on Feb 29, 2024

  1. We already serializes these as a hash, no need for default_value_for

    @jrafanie
    jrafanie committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    0869343 View commit details
    Browse the repository at this point in the history

  2. Replace default_value_for with simple fetch defaults

    @jrafanie
    jrafanie committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    760f8df View commit details
    Browse the repository at this point in the history

  3. Remove default_value_for usage where database defaults can be used 

    Depends on ManageIQ/manageiq-schema#721

Some of the remaining ones have custom defaults in STI or STI-like
subclasses, meaning we can't easily replace these with db defaults.

Defaults set in a subclass, not base class, in STI/STI like behavior:

  app/models/miq_provision_request.rb:  default_value_for :source_type,  "VmOrTemplate"
  app/models/service_template_provision_request.rb:  default_value_for :process,      false (overrides base class default)
  manageiq/providers/embedded_automation_manager/configuration_script_source.rb:  attribute :scm_type, :default => "git"
  manageiq/providers/embedded_automation_manager/configuration_script_source.rb:  attribute :scm_branch, :default => "master"

  manageiq/providers/cloud_manager/template.rb:  attribute :cloud, :default => true
  manageiq/providers/cloud_manager/vm.rb:  attribute :cloud, :default => true
  manageiq/providers/infra_manager/template.rb:  attribute :cloud, :default => false
  manageiq/providers/infra_manager/vm.rb:  attribute :cloud, :default => false
  manageiq/providers/physical_infra_manager/vm.rb:  attribute :cloud, :default => false

  app/models/service_retire_task.rb:  default_value_for :request_type, "service_retire"
  app/models/vm_migrate_task.rb:  default_value_for :request_type, "vm_migrate"
  app/models/vm_retire_task.rb:  default_value_for :request_type, "vm_retire"

  service_reconfigure_request.rb:  attribute :source_type, :default => SOURCE_CLASS_NAME
  service_template_provision_request.rb:  attribute :source_type, :default => SOURCE_CLASS_NAME
  vm_retire_request.rb:  attribute :source_type, :default => SOURCE_CLASS_NAME
  change_column_default :orchestration_stack_retire_tasks, :request_type,  :from => nil, :to => "orchestration_stack_retire"

Others, use block notation and isn't replaceable with database defaults.
We tried attribute defaults before but they trigger "changes" when the defaults
get set, which leads to unexpected changes in behavior.
    @jrafanie
    jrafanie committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    7fc7ec4 View commit details
    Browse the repository at this point in the history