-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dialog tag specs #23155
Open
GilbertCherrie
wants to merge
1
commit into
ManageIQ:master
Choose a base branch
from
GilbertCherrie:fix_dialog_tag_specs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix dialog tag specs #23155
GilbertCherrie
wants to merge
1
commit into
ManageIQ:master
from
GilbertCherrie:fix_dialog_tag_specs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
from
August 20, 2024 13:19
39a913b
to
78a4213
Compare
This was referenced Aug 21, 2024
@miq-bot cross-repo-test ManageIQ/manageiq-automation_engine#555 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 21, 2024
From Pull Request: ManageIQ/manageiq#23155
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 21, 2024
From Pull Request: ManageIQ/manageiq#23155
This was referenced Aug 21, 2024
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 21, 2024
From Pull Request: ManageIQ/manageiq#23155
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 21, 2024
From Pull Request: ManageIQ/manageiq#23155
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
2 times, most recently
from
August 21, 2024 19:07
f7f5bc1
to
ee5e5b6
Compare
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 21, 2024
From Pull Request: ManageIQ/manageiq#23155
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 21, 2024
From Pull Request: ManageIQ/manageiq#23155
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
from
August 23, 2024 18:17
ee5e5b6
to
4a1e580
Compare
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 23, 2024
From Pull Request: ManageIQ/manageiq#23155
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 23, 2024
From Pull Request: ManageIQ/manageiq#23155
This was referenced Aug 23, 2024
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
from
August 23, 2024 18:48
4a1e580
to
3fd528c
Compare
agrare
reviewed
Aug 23, 2024
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 26, 2024
From Pull Request: ManageIQ/manageiq#23155
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 26, 2024
From Pull Request: ManageIQ/manageiq#23155
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
4 times, most recently
from
August 26, 2024 20:19
9e8df23
to
64520e3
Compare
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 26, 2024
From Pull Request: ManageIQ/manageiq#23155
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Aug 26, 2024
From Pull Request: ManageIQ/manageiq#23155
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
5 times, most recently
from
September 5, 2024 17:55
15b03f3
to
4b50a80
Compare
GilbertCherrie
force-pushed
the
fix_dialog_tag_specs
branch
from
September 5, 2024 18:25
4b50a80
to
be8000f
Compare
Checked commit GilbertCherrie@be8000f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint app/models/service_orchestration/provision_tagging.rb
|
This pull request is not mergeable. Please rebase and repush. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: ManageIQ/manageiq-automation_engine#555
Fixes specs after automation engine code is changed for the tag field in this pr: ManageIQ/manageiq-automation_engine#555.
Reverting the tests back to before this pr: #23078