Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenShift Virtualization vendor types for VMs and hosts #23165

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

nasark
Copy link
Member

@nasark nasark commented Aug 29, 2024

These will be needed after the introduction of the OSV provider as its own separate provider

Needed for:

@miq-bot assign @agrare
@miq-bot add_label enhancement, providers, radjabov/yes?
@miq-bot add_reviewer @agrare

@miq-bot
Copy link
Member

miq-bot commented Aug 29, 2024

Checked commit nasark@a9643b9 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy
Copy link
Member

Fryguy commented Aug 29, 2024

@nasark Does this depend on ManageIQ/manageiq-providers-openshift#264 or is it the other way around?

@agrare
Copy link
Member

agrare commented Aug 29, 2024

I think it is the other way around, that provider PR can't go green without this

@nasark
Copy link
Member Author

nasark commented Aug 29, 2024

Yes it's the other way around

@agrare agrare merged commit 617c3d9 into ManageIQ:master Sep 10, 2024
8 checks passed
@Fryguy
Copy link
Member

Fryguy commented Oct 8, 2024

Backported to radjabov in commit cd26d5d.

commit cd26d5d38deb5d3d8ca5fa496b6a0e2bb1e61b15
Author: Adam Grare <adam@grare.com>
Date:   Tue Sep 10 11:35:47 2024 -0400

    Merge pull request #23165 from nasark/add_osv_vendor_types
    
    Add OpenShift Virtualization vendor types for VMs and hosts
    
    (cherry picked from commit 617c3d9d2b86b2f2cec62c57c796c938ba6fc478)

Fryguy pushed a commit that referenced this pull request Oct 8, 2024
Add OpenShift Virtualization vendor types for VMs and hosts

(cherry picked from commit 617c3d9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants