Mark workers associated with failed systemd units as stopped #23182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
changed the title
agrare
changed the title
If a systemd unit is failed but there is still a miq_worker record associated with it we should mark that worker record as stopped. This will then be cleaned up by the subsequent `clean_worker_records` method.
agrare
force-pushed
the
mark_workers_for_failed_units_stopped
branch
from
b1e30ad
to
728e223
Compare
|
Checked commits agrare/manageiq@2906f85~...728e223 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
changed the title
|
Okay I ran a live test on a master appliance build with this applied and I enable the embedded_terraform role first then set the container_image later and confirmed the failed workers are marked stopped and later deleted and then after the container_image setting is set properly the next time the worker starts up it pulls the correct image. Taking out of WIP |
Fryguy
approved these changes
Sep 27, 2024
|
Backported to |
Fryguy
added a commit
that referenced
this pull request
Oct 8, 2024
…topped Mark workers associated with failed systemd units as stopped (cherry picked from commit de72e9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we start a systemd unit and it fails this can leave the miq_worker record associated with it in "creating" without ever being cleaned up.
When we stop and cleanup any failed systemd units we should also mark any associated miq-worker records as stopped so that they can be cleaned up by the
clean_worker_recordsmethod.TODO
Fixes ManageIQ/manageiq-providers-embedded_terraform#59