Fix sporadic blacklist spec #23190
Merged
Fix sporadic blacklist spec #23190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
sporadic_blacklist_fix
branch
from
377f9aa
to
301717e
Compare
|
update:
|
Fryguy
reviewed
Sep 17, 2024
kbrock
force-pushed
the
sporadic_blacklist_fix
branch
from
301717e
to
9cabad9
Compare
|
update:
|
kbrock
force-pushed
the
sporadic_blacklist_fix
branch
from
9cabad9
to
4a870c4
Compare
|
update:
update:
|
Even though we stub_const for our classes (so they go away) It isn't for a number of gc cycles until it will get cleared up in the meantime, it will be returned from Class#subclasses Solution: punt. let it return from subclasses. But put a more robust implementation into our temporary ExtManagementSystem So they behave properly and don't freak out the blacklist specs
kbrock
force-pushed
the
sporadic_blacklist_fix
branch
from
4a870c4
to
c72f6c3
Compare
|
Checked commit kbrock@c72f6c3 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we stub_const for our classes (so they go away) It isn't for a number of gc cycles until it will get cleared up
in the meantime, it will be returned from Class#subclasses
Solution: punt. let it return from subclasses.
But put a more robust implementation into our temporary ExtManagementSystem So they behave properly and don't freak out the blacklist specs
Fixes #23152
reproducer: