spec: Support ruby 3.1 and 3.3 error message formats #23203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
Merged
Fryguy
reviewed
Sep 24, 2024
| @@ -257,12 +257,12 @@ def test_method | |||
| expect(api_collection).to receive(:find).with(0).and_return(Struct.new(:id).new(0)) | |||
| expect(api_collection).to receive(:find).with(1).and_return(double("Something that responds", :id => 0, :the_task => nil)) | |||
|
|
|||
| expect($log).to receive(:error).with(a_string_including("undefined method `the_task' for #<struct id=0>")).and_call_original | |||
| expect($log).to receive(:error).with(a_string_matching(/undefined method `the_task' for/)).and_call_original | |||
There was a problem hiding this comment.
This doesn't really use a regex so what about:
Suggested change
| expect($log).to receive(:error).with(a_string_matching(/undefined method `the_task' for/)).and_call_original | |
| expect($log).to receive(:error).with(a_string_including("undefined method `the_task' for")).and_call_original |
|
Label says 3.2, but the title says 3.3 - do you know which one introduced the change? |
This message is different for ruby 3.3 and 3.1 Change phrase to be the common factor for both ruby versions
kbrock
force-pushed
the
flexible_error_matcher_ruby31
branch
from
325a347
to
076fdf5
Compare
|
update:
|
|
Checked commit kbrock@076fdf5 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
Fryguy
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This message is different for ruby 3.3 and 3.1
Change phrase to be the common factor for both ruby versions
This is currently the only failure for 3.1/3.3 on master
(besides the gem changes)