-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update English Translations #23233
Update English Translations #23233
Conversation
@jrafanie Does it make sense to change the automated PRs to update the non-english message catalogs, particularly when a string is deleted? The reason that #23218 is failing is because the non-english catalogs still have the old strings, even though they've been deleted in the .pot and the english .po. I was hoping this PR would have those strings removed from the non-english catalogs, but that's not how it works currently. |
Maybe but that's not how the workflow occurs. We don't ever really merge the non-english po files except from translators. If we remove things in the english pot, it should be removed when the translators apply the changes and provide the updated po files. |
c9ad7a8
to
7ca1e98
Compare
7ca1e98
to
bd948a0
Compare
bd948a0
to
f48b179
Compare
Checked commit miq-bot@f48b179 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
@@ -19393,9 +19393,6 @@ msgstr "" | |||
msgid "Edit this Provider" | |||
msgstr "" | |||
|
|||
msgid "Edit this Region" | |||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in ManageIQ/manageiq-ui-classic#9270
msgid "" | ||
"Host to validate against, Username and matching password fields are needed to " | ||
"perform verification of credentials" | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in ManageIQ/manageiq-ui-classic#9288
@@ -12962,9 +12959,6 @@ msgstr "" | |||
msgid "Copy from provisioning" | |||
msgstr "" | |||
|
|||
msgid "Copy object details for use in a Button" | |||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in ManageIQ/manageiq-ui-classic#9308
@@ -879,9 +879,6 @@ msgstr "" | |||
msgid "%{name} (All %{title})" | |||
msgstr "" | |||
|
|||
msgid "%{name} (All Generic Objects)" | |||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed in ManageIQ/manageiq-ui-classic#9266
|
||
msgid "EVM: Recently Discovered VMs" | ||
msgstr "" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added back in #23264
"ct copied from the Simulation screen" | ||
msgstr "" | ||
|
||
msgid "Paste object details for use in a Button." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also removed in ManageIQ/manageiq-ui-classic#9308
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging
The parent commits that this depends on were already brought back in radjabov. |
Update the English Translations in the manageiq.po and manageiq.pot files.