Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the fixed syntax for IPv6 safe URI building via a backport. #2325

Merged
merged 2 commits into from
Mar 24, 2015

Conversation

jrafanie
Copy link
Member

The backport in #2172 enables us to use the fixed syntax now.

From #2172:

Before backport:

 # Don't pass :host => "::1" to .build as it throws URI::InvalidComponentError
 uri = URI::HTTPS.build(:path => "/sdk")
 uri.hostname = "::1"
 uri.to_s # => "https://[::1]/sdk"

After(client doesn't need to use hostname= method):

 uri = URI::HTTPS.build(:host => "::1", :path => "/sdk")
 uri.to_s # => "https://[::1]/sdk"

The backport in ManageIQ#2172 enables us to use the fixed syntax now.
@Fryguy
Copy link
Member

Fryguy commented Mar 24, 2015

👍

@miq-bot
Copy link
Member

miq-bot commented Mar 24, 2015

Checked commits jrafanie@af55b05 .. jrafanie@a987dc3 with rubocop 0.27.1
6 files checked, 2 offenses detected

lib/VMwareWebService/MiqVimClientBase.rb

Fryguy added a commit that referenced this pull request Mar 24, 2015
Use the fixed syntax for IPv6 safe URI building via a backport.
@Fryguy Fryguy merged commit 7cc75e4 into ManageIQ:master Mar 24, 2015
@Fryguy Fryguy deleted the cleanup_ipv6_workaround branch March 24, 2015 17:08
@Fryguy Fryguy added this to the Sprint 21 Ending Mar 30, 2015 milestone Mar 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants