Event switchboard #4328

lfu · 2015-09-11T19:18:59Z

Handle all events via automate.

https://bugzilla.redhat.com/show_bug.cgi?id=1252485

chessbyte · 2015-09-22T18:04:36Z

@lfu Please address the failing specs
/cc @gmcculloug

lfu · 2015-09-22T18:07:16Z

I’m working on it.

On Sep 22, 2015, at 2:04 PM, Oleg Barenboim notifications@github.com wrote:

@lfu https://github.com/lfu Please address the failing specs
/cc @gmcculloug https://github.com/gmcculloug
—
Reply to this email directly or view it on GitHub #4328 (comment).

chessbyte · 2015-09-29T10:47:51Z

@gmcculloug please review

miq-bot · 2015-10-01T02:37:33Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

miq-bot · 2015-10-02T00:39:23Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

chessbyte · 2015-10-02T00:40:57Z

@lfu Please rebase and push again

miq-bot · 2015-10-02T21:58:01Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

chessbyte · 2015-10-02T22:19:51Z

Please rebase and push again

miq-bot · 2015-10-08T19:43:26Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

miq-bot · 2015-10-12T19:39:39Z

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

lfu · 2015-10-13T15:19:23Z

@miq-bot add_label wip
I am going to split the PR as small as possible.

miq-bot · 2015-10-13T15:20:09Z

@lfu unrecognized command 'add_lable', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

miq-bot · 2015-10-13T15:22:08Z

@lfu Cannot apply the following label because they are not recognized: WIP

miq-bot · 2015-10-13T15:22:09Z

@lfu Cannot apply the following label because they are not recognized: WIP

All MiqEvents are sent to automate asynchronously. Once MiqEvent is handled by automate, a MiqQueue callback checks the policy resolution result and moves VmScan into next state.

to raise the event to automate synchronously while call_automate_event does it asynchronously.

for the MiqRequest events.

policy_prevented? in VmOrTemplate and Host expects MiqException::PolicyPreventAction from policy resolution when the event is prevented from policy. With event switchboard, all events are raised to automate and get processed asynchronously. Use the MiqQueue callback to proceed when automate is done.

Retirement event is one of the Policy events. MiqEvent.raise_evm_event would create a MiqEvent object for the event, then raise the event to automate. All events sent to automate require an EventStream object in the URI with Switchboard changes.

MiqEvent.raise_evm_event creates an MiqEvent object then sends the event to automate. In event switchboard, all events are sent to automate and require an EventStream object for automate process.

… to automate.

…asynchronously.

miq-bot · 2015-10-24T18:58:53Z

Checked commits lfu/manageiq@7253fe7~...349281c with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0
33 files checked, 18 offenses detected

app/models/miq_event.rb

🔹 - Line 19, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for raise_evm_event is too high. [16.82/15]
🔹 - Line 44, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for process_evm_event is too high. [41.3/15]

app/models/miq_request.rb

🔴 Warn - Line 147, Col 5 - Lint/UselessAssignment - Useless assignment to variable - message.

app/models/vm_or_template.rb

🔹 - Line 355, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for enforce_policy is too high. [19.92/15]
🔹 - Line 355, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for enforce_policy is too high. [7/6]

app/models/vm_scan.rb

🔶 - Line 27, Col 31 - Style/AlignHash - Align the elements of a hash literal if they span more than one line.
🔹 - Line 38, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for call_check_policy is too high. [17.49/15]
🔹 - Line 62, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for check_policy_complete is too high. [19/15]
🔹 - Line 62, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for check_policy_complete is too high. [7/6]
🔹 - Line 82, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for call_snapshot_create is too high. [112/15]
🔹 - Line 82, Col 3 - Metrics/CyclomaticComplexity - Cyclomatic complexity for call_snapshot_create is too high. [16/6]
🔹 - Line 82, Col 3 - Metrics/MethodLength - Method has too many lines. [83/25]
🔹 - Line 82, Col 3 - Metrics/PerceivedComplexity - Perceived complexity for call_snapshot_create is too high. [20/7]

lib/miq_automation_engine/engine/miq_ae_event.rb

🔶 - Line 119, Col 27 - Style/ExtraSpacing - Unnecessary spacing detected.

spec/lib/miq_automation_engine/miq_ae_discovery_spec.rb

🔶 - Line 46, Col 10 - Style/IndentationConsistency - Inconsistent indentation detected.

spec/models/host_spec.rb

🔹 - Line 146, Col 121 - Metrics/LineLength - Line is too long. [125/120]

spec/models/miq_request_spec.rb

🔹 - Line 89, Col 121 - Metrics/LineLength - Line is too long. [125/120]

spec/models/vm_spec.rb

🔹 - Line 180, Col 121 - Metrics/LineLength - Line is too long. [123/120]

Event switchboard

lfu · 2015-10-26T13:39:57Z

@miq-bot remove_label wip

chessbyte added enhancement core/policy labels Sep 15, 2015

lfu force-pushed the async_event_with_stream branch 5 times, most recently from 5c5d243 to ad4bf35 Compare September 23, 2015 15:25

lfu force-pushed the async_event_with_stream branch from ad4bf35 to 188c64c Compare October 1, 2015 13:22

lfu force-pushed the async_event_with_stream branch from 188c64c to 0ca6b82 Compare October 2, 2015 13:33

lfu force-pushed the async_event_with_stream branch from 0ca6b82 to 4445f8b Compare October 2, 2015 23:30

lfu force-pushed the async_event_with_stream branch from 4445f8b to f71595f Compare October 9, 2015 15:08

chessbyte changed the title ~~Event switchboard.~~ Event switchboard Oct 9, 2015

lfu force-pushed the async_event_with_stream branch from f71595f to e597ef8 Compare October 12, 2015 21:10

This was referenced Oct 13, 2015

Changes due to the rename of MiqEvent to MiqEventDefinition. #4835

Merged

Remove outdated event methods #4836

Merged

Use automate method for EmsEvent to handle events. #4842

Merged

lfu added 12 commits October 24, 2015 14:29

Add a new state wait_for_policy to VmScan.

58d5ed3

All MiqEvents are sent to automate asynchronously. Once MiqEvent is handled by automate, a MiqQueue callback checks the policy resolution result and moves VmScan into next state.

Add test cases for the new state in VmScan.

b26431d

Add method call_automate_event_sync

b277378

to raise the event to automate synchronously while call_automate_event does it asynchronously.

Add a new subclass of EventStream - RequestEvent

3ec02e2

for the MiqRequest events.

Expose RequestEvent to automate.

c18de69

Add RequestEvent into automate modeling

a4cdd82

Fix MiqAlert to call MiqEvent.raise_evm_event.

f842a19

MiqEvent.raise_evm_event creates an MiqEvent object then sends the event to automate. In event switchboard, all events are sent to automate and require an EventStream object for automate process.

Changes to test cases due to admin user is required to raise an event…

610eee5

… to automate.

Fix rubocop warnings

0664479

Fix test cases for MiqAeEvent due to all events are sent to automate …

349281c

…asynchronously.

lfu force-pushed the async_event_with_stream branch from 0f2b969 to 349281c Compare October 24, 2015 18:47

gmcculloug added a commit that referenced this pull request Oct 26, 2015

Merge pull request #4328 from lfu/async_event_with_stream

0b7979b

Event switchboard

gmcculloug merged commit 0b7979b into ManageIQ:master Oct 26, 2015

gmcculloug added this to the Sprint 31 Ending Oct 26, 2015 milestone Oct 26, 2015

miq-bot removed the wip label Oct 26, 2015

gmcculloug mentioned this pull request Oct 27, 2015

Collect additional container provider events #5015

Merged

lfu deleted the async_event_with_stream branch October 27, 2015 13:54

This was referenced Oct 27, 2015

Follow-up on event switchboard: event_handling section #5155

Merged

Change the criteria when an event is not being raised to automate #5188

Merged

Retirement events should go to System/Event/MiqEvent. #5189

Merged

lfu mentioned this pull request Dec 3, 2015

All RequestEvent should go to /System/Event/RequestEvent/Request. #5695

Merged

lfu mentioned this pull request Jan 12, 2016

Fix Alert for Management Event. #6156

Merged

lfu mentioned this pull request Mar 21, 2017

Add policy checking for request_host_scan. #14427

Merged

This was referenced Apr 4, 2017

Add policy checking for the retirement request. ManageIQ/manageiq-content#86

Merged

Add policy checking for retirement request. #14641

Merged

lfu mentioned this pull request Jan 9, 2018

[WIP] Catch the provider side errors during VM start in the provision. #16782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event switchboard #4328

Event switchboard #4328

lfu commented Sep 11, 2015

chessbyte commented Sep 22, 2015

lfu commented Sep 22, 2015

chessbyte commented Sep 29, 2015

miq-bot commented Oct 1, 2015

miq-bot commented Oct 2, 2015

chessbyte commented Oct 2, 2015

miq-bot commented Oct 2, 2015

chessbyte commented Oct 2, 2015

miq-bot commented Oct 8, 2015

miq-bot commented Oct 12, 2015

lfu commented Oct 13, 2015

miq-bot commented Oct 13, 2015

miq-bot commented Oct 13, 2015

miq-bot commented Oct 13, 2015

miq-bot commented Oct 24, 2015

lfu commented Oct 26, 2015

Event switchboard #4328

Event switchboard #4328

Conversation

lfu commented Sep 11, 2015

chessbyte commented Sep 22, 2015

lfu commented Sep 22, 2015

chessbyte commented Sep 29, 2015

miq-bot commented Oct 1, 2015

miq-bot commented Oct 2, 2015

chessbyte commented Oct 2, 2015

miq-bot commented Oct 2, 2015

chessbyte commented Oct 2, 2015

miq-bot commented Oct 8, 2015

miq-bot commented Oct 12, 2015

lfu commented Oct 13, 2015

miq-bot commented Oct 13, 2015

miq-bot commented Oct 13, 2015

miq-bot commented Oct 13, 2015

miq-bot commented Oct 24, 2015

lfu commented Oct 26, 2015