Vim performance scope #7260
Vim performance scope #7260
Conversation
|
@gtanzillo please review |
|
|
||
| if obj.kind_of?(MiqEnterprise) || obj.kind_of?(MiqRegion) | ||
| cond1 = klass.send(:sanitize_sql_for_conditions, :resource_type => "Storage", :resource_id => obj.storage_ids) | ||
| cond2 = klass.send(:sanitize_sql_for_conditions, :resource_type => "ExtManagementSystem", :resource_id => obj.ext_management_system_ids) | ||
| cond += " AND ((#{cond1}) OR (#{cond2}))" | ||
| rel = rel.where("((#{cond1}) OR (#{cond2}))") |
There was a problem hiding this comment.
While we're here, you can or this, and thus kill the sanitize calls.
There was a problem hiding this comment.
@matthewd that was my question - what does this OR code look like?
There was a problem hiding this comment.
rel = rel.where(resource: obj.storages).or(rel.where(resource: obj.ext_management_systems))
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
kbrock
force-pushed
the
vim_performance_scope
branch
from
bb29dad
to
80d4fe4
Compare
|
WIPping until I get a test into here |
kbrock
force-pushed
the
vim_performance_scope
branch
2 times, most recently
from
19af989
to
81fd207
Compare
|
remove call to VimPerformanceDaily#find_entries with :reflections It is ignored
convert timestamp and other conditions to scope
VimPerformanceAnalysis.find_perf_for_time_period and child version call into VimPerformanceDaily.find_entries, and does not use :only_cols
kbrock
force-pushed
the
vim_performance_scope
branch
from
81fd207
to
67fff45
Compare
|
fixed rubocops. @matthewd Think I addressed all your concerns/suggestions. Followup PR extracts the scopes and sunsets |
kbrock
force-pushed
the
vim_performance_scope
branch
from
67fff45
to
ef808e3
Compare
|
Checked commits kbrock/manageiq@7aa7690~...ef808e3 with ruby 2.2.3, rubocop 0.37.2, and haml-lint 0.16.1 app/models/miq_report/generator/utilization.rb
spec/models/vim_performance_analysis_spec.rb
|
This is focused on
VimPerformanceDaily.find_entriesThe goal is to remove allow scopes to be used instead. Rbac will be able to convert
VimPerformanceDailyinto a scope and much of the specialized logic aroundscopeandklasscan be removed.After this, think we can pull
klasslookup out offind_entriesLet me know the best way to code the
ORif you think I should convert that too./cc @matthewd This is a follow up to our conversation.