Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using manageiq-style for linting dependencies #506

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented May 19, 2020

Gemfile Outdated Show resolved Hide resolved
@Fryguy
Copy link
Member

Fryguy commented May 22, 2020

@bdunne I know you're still in the middle of this, but please also change the plugin generator to include these changes.

Gemfile.lock Outdated Show resolved Hide resolved
@kbrock
Copy link
Member

kbrock commented May 26, 2020

fun stuff. thank you brandon

@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2020

Checked commit bdunne@d9479cd with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
2 files checked, 2 offenses detected

**

  • 💣 💥 🔥 🚒 - Linter/Rubocop - Linter::Rubocop STDERR:
Unable to find gem manageiq-style; is the gem installed? Gem::MissingSpecError
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader_resolver.rb:195:in `rescue in gem_config_path'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader_resolver.rb:191:in `gem_config_path'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader_resolver.rb:48:in `block (2 levels) in resolve_inheritance_from_gems'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader_resolver.rb:46:in `reverse_each'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader_resolver.rb:46:in `block in resolve_inheritance_from_gems'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader_resolver.rb:39:in `each_pair'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader_resolver.rb:39:in `resolve_inheritance_from_gems'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader.rb:49:in `load_file'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_loader.rb:86:in `configuration_from_file'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/config_store.rb:44:in `for'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/target_finder.rb:110:in `excluded_dirs'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/target_finder.rb:88:in `find_files'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/target_finder.rb:60:in `target_files_in_dir'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/target_finder.rb:31:in `find'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/runner.rb:64:in `find_target_files'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/runner.rb:34:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/cli.rb:210:in `execute_runner'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/cli.rb:80:in `execute_runners'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/lib/rubocop/cli.rb:51:in `run'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/exe/rubocop:13:in `block in <top (required)>'
/usr/local/lib/ruby/2.5.0/benchmark.rb:308:in `realtime'
/usr/local/lib/ruby/gems/2.5.0/gems/rubocop-0.69.0/exe/rubocop:12:in `<top (required)>'
/usr/local/bin/rubocop:23:in `load'
/usr/local/bin/rubocop:23:in `<main>'

  • 💣 💥 🔥 🚒 - Linter/Yaml - missing config files

@Fryguy Fryguy merged commit 915a828 into ManageIQ:master Oct 21, 2020
@bdunne bdunne deleted the use_manageiq-style branch October 22, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants