Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML replacing on: with true: in github workflow #580

Merged

Conversation

agrare
Copy link
Member

@agrare agrare commented Feb 9, 2022

(byebug) pp github_workflow_yml_content
"---\n" +
"name: Cross Repo Tests\n" +
"on:\n" +
"- pull_request\n" +
"jobs:\n" +
"  cross-repo:\n" +
"    uses: ManageIQ/manageiq-cross_repo/.github/workflows/manageiq_cross_repo.yaml@master\n" +
"    with:\n" +
"      test-repos: '[\"foo\", \"bar\"]'\n" +
"      repos: repo1,repo2\n"

@agrare
Copy link
Member Author

agrare commented Feb 9, 2022

@agrare agrare requested a review from Fryguy February 9, 2022 16:39
@agrare agrare force-pushed the fix_yaml_load_replacing_on_with_true branch from 3b984be to 8473885 Compare February 9, 2022 16:41
@miq-bot
Copy link
Member

miq-bot commented Feb 9, 2022

Checked commit agrare@8473885 with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@Fryguy Fryguy merged commit 4e593a7 into ManageIQ:master Feb 9, 2022
@agrare agrare deleted the fix_yaml_load_replacing_on_with_true branch February 9, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants