Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #126

Merged
merged 2 commits into from
Feb 14, 2022
Merged

Migrate to GitHub Actions #126

merged 2 commits into from
Feb 14, 2022

Conversation

petergoldstein
Copy link
Contributor

This PR moves CI to GitHub Actions

In addition to setting up a basic configuration that includes those Rubies previously tested by Travis this PR:

  1. Adds jruby-9.3 and Ruby 3.1 to the CI matrix
  2. Loosens the Rake requirement in the gemspec to allow a Rake version that's compatible with ruby-head

@petergoldstein
Copy link
Contributor Author

Looks like GitHub Actions needs to be enabled on this repo. On my fork this runs green. - https://github.com/petergoldstein/optimist/actions/runs/1842346534

@Fryguy
Copy link
Member

Fryguy commented Feb 14, 2022

Looks like GitHub Actions needs to be enabled on this repo. On my fork this runs green. - https://github.com/petergoldstein/optimist/actions/runs/1842346534

It's on by default in our org, but for some reason GitHub doesn't run it on the main repo until it's merged the first time. I presume to avoid people creating PRs with Bitcoin miners to unsuspecting repos. 🤷

@Fryguy Fryguy merged commit 7d5ed15 into ManageIQ:master Feb 14, 2022
@Fryguy
Copy link
Member

Fryguy commented Feb 14, 2022

Thank you so much!

@chessbyte
Copy link
Member

Thank you @petergoldstein
@Fryguy do we need a follow-up PR to remove https://github.com/ManageIQ/optimist/blob/master/.travis.yml ?

@Fryguy
Copy link
Member

Fryguy commented Feb 14, 2022

Yes I added a note to the big checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants