fixes frozen string issue on old rb2.7, removed useless code #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanobowers
commented
May 2, 2024
| @@ -248,7 +248,6 @@ def educate_on_error | |||
|
|
|||
| def handle_unknown_argument(arg, candidates, suggestions) | |||
| errstring = "unknown argument '#{arg}'" | |||
| errstring += " for command '#{subcommand_name}'" if self.respond_to?(:subcommand_name) | |||
There was a problem hiding this comment.
this was a cut and paste error from optimist-xl, is unneeded and shouldve been removed.
Fryguy
approved these changes
May 2, 2024
Fryguy
added a commit
that referenced
this pull request
Nov 11, 2024
Added: - Align the short and long forms into their own columns in the help output (#145 - thanks akhoury6) - Add support for DidYouMean when long options are spelled incorrectly (#150 - thanks nanobowers) - Using `permitted:` restricts the allowed values that a end-user inputs to a pre-defined list (#147 - thanks akhoury6) - Add exact_match to settings, defaulting to inexact matching (#154 - thanks nanobowers) - Add setting to disable implicit short options (#155 - thanks nanobowers) - Add alt longname and multiple char support (#151 - thanks nanobowers) - Permitted regexp/range support (#158, #159- thanks nanobowers) - Add some examples (#161 - thanks nanobowers) Changed: - Enable frozen_string_literal for future-ruby support (#149, #153 - thanks nanobowers) - Refactor constraints (#156 - thanks nanobowers) - Fix assert_raises to assert_raises_errmatch (#160 - thanks nanobowers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of did-you-mean branch and frozen-string literal branch caused this issue, as the DYM branch did not fully abide by frozen-string literal rules.
Funny enough, behavior of the frozen-string-literal comment is different on rb2.7 and 3.x
Fixes fails mentioned #152
@miq-bot add-label bug
@miq-bot add-reviewer @Fryguy