dialog-user: Move tagging fix from #412 to setDefaultValue #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialogField component should not be changing default_value, the dialogData service is the place where default_value gets set. https://bugzilla.redhat.com/show_bug.cgi?id=1729379
|
Checked commit https://github.com/himdel/ui-components/commit/403703b65ff20b3225ba5e35ab06f747718cbfc6 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
romanblanco
approved these changes
Sep 4, 2019
simaishi
pushed a commit
that referenced
this pull request
Sep 4, 2019
dialog-user: Move tagging fix from #412 to setDefaultValue (cherry picked from commit b224a50) https://bugzilla.redhat.com/show_bug.cgi?id=1749061
|
Hammer backport details: |
|
@himdel realizing now, that we don't allow setting a default value for Tag Control in Dialog Editor, the test |
This was referenced Sep 5, 2019
This was referenced Oct 23, 2019
simaishi
pushed a commit
that referenced
this pull request
Nov 1, 2019
dialog-user: Move tagging fix from #412 to setDefaultValue (cherry picked from commit b224a50) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1767836
|
Ivanchuk backport details: |
This was referenced Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(follow-up to #412)
The dialogField component should not be changing default_value,
the dialogData service is the place where default_value gets set.
Otherwise, validations from dialog-user and from dialog-field will work with different values, which can cause invalid validations or validation loops.
(docs - https://github.com/ManageIQ/manageiq-ui-classic/wiki/Dialogs#dialog-user-tidbits)
https://bugzilla.redhat.com/show_bug.cgi?id=1729379
Cc @romanblanco @h-kataria