Clean build process so there are no more errors with missing __ function #77
Conversation
|
@romanblanco I was unable to find where dialog editor is used in SUI so I am unable to test this directly in there. Could you try it if it does not break anything? |
|
@karelhala it is not used in SUI anymore. It was removed in PR ManageIQ/manageiq-ui-service#688. Right now, there is just PR adding it into Ops UI: ManageIQ/manageiq-ui-classic#1398, otherwise it's not used anywhere right now |
| @@ -9,7 +10,7 @@ class DialogField { | |||
| options: any = {}) { | |||
| this.icon = icon; | |||
| this.label = label; | |||
| this.placeholders = Object.assign({ | |||
| this.placeholders = (<any>Object).assign({ | |||
There was a problem hiding this comment.
This one sounds wrong .. any way to teach tslint about es6-shim? Or, to assume all ES6 methods are available?
There was a problem hiding this comment.
(the method is defined in ./node_modules/typescript/lib/lib.es6.d.ts, just not sure how to make it use that without using target: "es6")
There was a problem hiding this comment.
... actually, this works (but not sure if quite the right place..)
diff --git a/tsconfig.json b/tsconfig.json
index 3093662..c97da88 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -7,6 +7,7 @@
"typeRoots" : ["./node_modules/@types"]
},
"files": [
+ "node_modules/typescript/lib/lib.es6.d.ts",
"src/index.ts"
],
"exclude": [There was a problem hiding this comment.
@karelhala So looks like this is the proper fix:
diff --git a/tsconfig.json b/tsconfig.json
index 3093662..4d3d5e9 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -4,7 +4,8 @@
"module": "commonjs",
"removeComments": false,
"sourceMap": true,
- "typeRoots" : ["./node_modules/@types"]
+ "typeRoots" : ["./node_modules/@types"],
+ "lib": ["es2015", "DOM", "ScriptHost"]
},
"files": [
"src/index.ts"WDYT?
(From microsoft/TypeScript#3429 (comment) )
EDIT: added DOM to prevent new warnings :). (a list)
EDIT2: added ScriptHost too since it's the default when you don't have lib
There was a problem hiding this comment.
Thank you, looks much better! 👍
|
@karelhala I guess you need to rebase.. I'm starting to wonder whether we need a separate repo (autogenerated on change) for EDIT: done in #83, to a separate branch ( |
|
@himdel that sounds like a cleaner solution having |
This PR fixes errors which were shown in console if any phase of build was ran (
npm run buildornpm start). Helper function was introduced, which checks if__exists on window object and if it does not exists it will return string which was passed to it, if it exists it will return result of__(translateString).No UI changes.