Reconfigure VM: Add / Remove Network Adapters

[kruge002]

This PR adds the method getDeviceKeysByLabel to retrieve the network adapters device keys for the given network adapter label. This method is part of the new functionality added to the Reconfigure VM webpage.

This PR is part of a set of PRs:
#25
ManageIQ/manageiq-providers-vmware#163
ManageIQ/manageiq#16700
ManageIQ/manageiq-ui-classic#3121

More info: ManageIQ/manageiq-ui-classic#3119

[agrare]

Thanks for the PR @kruge002 !

Couple of comments, I think it would be great if you could model what we have for getScsiControllers but for ethernet cards.

[agrare]

This leaves out a few NIC types (VirtualE1000, VirtualVmxnet2), ideally what you'd want to do is dev.kind_of?(VirtualEthernetCard) but since xsiType is just a string that's not possible.

What we have instead to track VIM class inheritance is VimClass so you could add all of these as child classes of VirtualEthernetCard and do next unless VimClass.child_classes(:VirtualEthernetCard).include? dev.xsiType

Easier to just do what we do with VirtualScsiControllers

[agrare]

deviceInfo.label is "Network adapter 1", summary is what has the network name if it is a VM Network. This won't work if the NIC is on a dvPortGroup however because the deviceInfo.summary is e.g.: "DVSwitch: 50 3c b7 67 59 58 cf ce-75 16 2f e0 2b 6a d8 3c"

What you could do is check the backing, so e.g.

next unless case dev["backing"].xsiType
when "VirtualEthernetCardNetworkBackingInfo"
  dev["backing"]["deviceName"] == networkName
when "VirtualEthernetCardDistributedVirtualPortBackingInfo"
  dev["backing"]["port"]["portgroupKey"] == networkName # NOTE this will need to be the dvPortGroup ManagedObjectReference but this is the `Lan.uid_ems` for MIQ anyway
end

[agrare]

You can use getHardware which does getProp("config.hardware").try(:fetch_path, "config", "hardware") || {} for you

[kruge002]

@agrare Thanks for the feedback. I am working on it. You will hear back from me in the new year.

[miq-bot]

Checked commits kruge002/vmware_web_service@d017d23~...af8b1cd with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 6 offenses detected

lib/VMwareWebService/MiqVimVm.rb

• ❗ - Line 32, Col 33 - Style/MultilineArrayBraceLayout - Closing array brace must be on the same line as the last array element when opening brace is on the same line as the first array element.
• ❗ - Line 935, Col 28 - Style/VariableName - Use snake_case for variable names.
• ❗ - Line 935, Col 7 - Style/MethodName - Use snake_case for method names.
• ❗ - Line 936, Col 27 - Style/MethodCallWithoutArgsParentheses - Do not use parentheses for method calls with no arguments.
• ❗ - Line 942, Col 7 - Style/VariableName - Use snake_case for variable names.
• ❗ - Line 946, Col 5 - Style/RedundantParentheses - Don't use parentheses around a literal.

[agrare]

Looking good 😄 I still think you need to use the backing to find the network instead of the description so that it supports dvportgroups.

[kruge002]

@agrare I renamed the method getDeviceKeysByNetwork to getDeviceKeysByLabel because the method needs to find the device keys for the given Network Adapter label e.g. 'Network adapter 1'. The network name is not needed here so it will work for dvportgroups as well.

I will add a commit to solve the rubocop issues. I hope you will accept the codeclimate issue (Cognitive Complexity of 8 exceeds 5).

[agrare]

LGTM thanks @kruge002 !

[agrare]

@kruge002 I released v0.2.5 with these changes, thanks for your contributions!

[kruge002]

@agrare Thanks for the merge! One PR ready, three to go to completely add the "Add / Remove Network Adapter" functionality to "Reconfigure VM":
ManageIQ/manageiq-providers-vmware#163
ManageIQ/manageiq#16700
ManageIQ/manageiq-ui-classic#3121